Added support for Minecraft 1.20 #71

Merged
ShayanGsh merged 3 commits from main into main 2023-08-14 20:46:00 +00:00
ShayanGsh commented 2023-08-01 17:28:38 +00:00 (Migrated from github.com)

Upgraded MCProtocolLib version.

Upgraded MCProtocolLib version.
Norbiros (Migrated from github.com) requested changes 2023-08-08 11:17:29 +00:00
Norbiros (Migrated from github.com) left a comment

Can you also update README.md?

Can you also update `README.md`?
ShayanGsh commented 2023-08-09 18:03:59 +00:00 (Migrated from github.com)

I updated the version in readme and also the build version in gradle

I updated the version in readme and also the build version in gradle
Norbiros (Migrated from github.com) approved these changes 2023-08-09 18:07:56 +00:00
Norbiros (Migrated from github.com) left a comment

LGTM!

LGTM!
bananasmoothii commented 2023-08-11 10:39:08 +00:00 (Migrated from github.com)

I got this issue for one bot among 10 with ShayanGsh's fork:

[12:30:17] INFO | dRpkX6IR7KbuW1dy disconnected
[12:30:17] INFO |  -> java.lang.ClassCastException: class net.kyori.adventure.text.format.TextColorImpl cannot be cast to class net.kyori.adventure.text.format.NamedTextColor (net.kyori.adventure.text.format.TextColorImpl and net.kyori.adventure.text.format.NamedTextColor are in unnamed module of loader 'app')
ALL> java.lang.ClassCastException: class net.kyori.adventure.text.format.TextColorImpl cannot be cast to class net.kyori.adventure.text.format.NamedTextColor (net.kyori.adventure.text.format.TextColorImpl and net.kyori.adventure.text.format.NamedTextColor are in unnamed module of loader 'app')
        at me.creepermaxcz.mcbots.Utils.getFullText(Utils.java:45)
        at me.creepermaxcz.mcbots.Utils.getFullText(Utils.java:33)
        at me.creepermaxcz.mcbots.MainListener.packetReceived(MainListener.java:48)
        at com.github.steveice10.packetlib.tcp.TcpSession.callPacketReceived(TcpSession.java:157)
        at com.github.steveice10.packetlib.tcp.TcpSession.lambda$channelRead0$2(TcpSession.java:386)
        at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:1589)
[12:30:17] INFO |
[12:30:17] INFO | Bot with MainListener removed
[12:30:17] INFO | Renewing MainListener
[12:30:17] INFO | MainListener registered for: G8nWkK8xmv9BVMpB
[12:30:17] CHAT | [T] 7] dRpkX6IR7KbuW1dy left the game
[12:30:47] CHAT | : The event has begun. Good luck, G8nWkK8xmv9BVMpB!
[12:44:10] INFO | G8nWkK8xmv9BVMpB disconnected
[12:44:10] INFO |  -> java.lang.ClassCastException: class net.kyori.adventure.text.format.TextColorImpl cannot be cast to class net.kyori.adventure.text.format.NamedTextColor (net.kyori.adventure.text.format.TextColorImpl and net.kyori.adventure.text.format.NamedTextColor are in unnamed module of loader 'app')
ALL> java.lang.ClassCastException: class net.kyori.adventure.text.format.TextColorImpl cannot be cast to class net.kyori.adventure.text.format.NamedTextColor (net.kyori.adventure.text.format.TextColorImpl and net.kyori.adventure.text.format.NamedTextColor are in unnamed module of loader 'app')
        at me.creepermaxcz.mcbots.Utils.getFullText(Utils.java:45)
        at me.creepermaxcz.mcbots.MainListener.packetReceived(MainListener.java:48)
        at com.github.steveice10.packetlib.tcp.TcpSession.callPacketReceived(TcpSession.java:157)
        at com.github.steveice10.packetlib.tcp.TcpSession.lambda$channelRead0$2(TcpSession.java:386)
        at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:1589)
[12:44:10] INFO |
[12:44:10] INFO | Bot with MainListener removed
[12:44:10] INFO | Renewing MainListener
[12:44:10] INFO | MainListener registered for: jOSTQjVCbAi6m5tG
[12:44:11] CHAT | [T] 4] G8nWkK8xmv9BVMpB left the game
ALL>

When sending the message (formatted with MiniMessages): <#2FAFEE><b>Event<dark_gray>: </dark_gray><white>The event has begun.</white></b> Good luck, <player_name>!

It seems like the <b>Event<dark_gray> part got removed.

I used java -Xmx750M -jar mc-bots-1.2.8.jar -s localhost:25565 -c 10. Other infos:

System Info: Java 17 (OpenJDK 64-Bit Server VM 17.0.8+7-LTS) Host: Windows 11 10.0 (amd64)
Loading libraries, please wait...
2023-08-11 12:22:24,367 ServerMain WARN Advanced terminal features are not available in this environment
[12:22:29 INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[12:22:30 INFO]: Loaded 7 recipes
[12:22:30 INFO]: Starting minecraft server version 1.20.1
[12:22:30 INFO]: Loading properties
[12:22:30 INFO]: This server is running Paper version git-Paper-98 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: a40e48f)

The paper version I am using is old, that might be an issue.

I got this issue for one bot among 10 with [ShayanGsh's fork](https://github.com/ShayanGsh/mc-bots): ``` [12:30:17] INFO | dRpkX6IR7KbuW1dy disconnected [12:30:17] INFO | -> java.lang.ClassCastException: class net.kyori.adventure.text.format.TextColorImpl cannot be cast to class net.kyori.adventure.text.format.NamedTextColor (net.kyori.adventure.text.format.TextColorImpl and net.kyori.adventure.text.format.NamedTextColor are in unnamed module of loader 'app') ALL> java.lang.ClassCastException: class net.kyori.adventure.text.format.TextColorImpl cannot be cast to class net.kyori.adventure.text.format.NamedTextColor (net.kyori.adventure.text.format.TextColorImpl and net.kyori.adventure.text.format.NamedTextColor are in unnamed module of loader 'app') at me.creepermaxcz.mcbots.Utils.getFullText(Utils.java:45) at me.creepermaxcz.mcbots.Utils.getFullText(Utils.java:33) at me.creepermaxcz.mcbots.MainListener.packetReceived(MainListener.java:48) at com.github.steveice10.packetlib.tcp.TcpSession.callPacketReceived(TcpSession.java:157) at com.github.steveice10.packetlib.tcp.TcpSession.lambda$channelRead0$2(TcpSession.java:386) at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:1589) [12:30:17] INFO | [12:30:17] INFO | Bot with MainListener removed [12:30:17] INFO | Renewing MainListener [12:30:17] INFO | MainListener registered for: G8nWkK8xmv9BVMpB [12:30:17] CHAT | [T] 7] dRpkX6IR7KbuW1dy left the game [12:30:47] CHAT | : The event has begun. Good luck, G8nWkK8xmv9BVMpB! [12:44:10] INFO | G8nWkK8xmv9BVMpB disconnected [12:44:10] INFO | -> java.lang.ClassCastException: class net.kyori.adventure.text.format.TextColorImpl cannot be cast to class net.kyori.adventure.text.format.NamedTextColor (net.kyori.adventure.text.format.TextColorImpl and net.kyori.adventure.text.format.NamedTextColor are in unnamed module of loader 'app') ALL> java.lang.ClassCastException: class net.kyori.adventure.text.format.TextColorImpl cannot be cast to class net.kyori.adventure.text.format.NamedTextColor (net.kyori.adventure.text.format.TextColorImpl and net.kyori.adventure.text.format.NamedTextColor are in unnamed module of loader 'app') at me.creepermaxcz.mcbots.Utils.getFullText(Utils.java:45) at me.creepermaxcz.mcbots.MainListener.packetReceived(MainListener.java:48) at com.github.steveice10.packetlib.tcp.TcpSession.callPacketReceived(TcpSession.java:157) at com.github.steveice10.packetlib.tcp.TcpSession.lambda$channelRead0$2(TcpSession.java:386) at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:1589) [12:44:10] INFO | [12:44:10] INFO | Bot with MainListener removed [12:44:10] INFO | Renewing MainListener [12:44:10] INFO | MainListener registered for: jOSTQjVCbAi6m5tG [12:44:11] CHAT | [T] 4] G8nWkK8xmv9BVMpB left the game ALL> ``` When sending the message (formatted with [MiniMessages](https://docs.advntr.dev/minimessage/index.html)): `<#2FAFEE><b>Event<dark_gray>: </dark_gray><white>The event has begun.</white></b> Good luck, <player_name>!` It seems like the `<b>Event<dark_gray>` part got removed. I used `java -Xmx750M -jar mc-bots-1.2.8.jar -s localhost:25565 -c 10`. Other infos: ``` System Info: Java 17 (OpenJDK 64-Bit Server VM 17.0.8+7-LTS) Host: Windows 11 10.0 (amd64) Loading libraries, please wait... 2023-08-11 12:22:24,367 ServerMain WARN Advanced terminal features are not available in this environment [12:22:29 INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD' [12:22:30 INFO]: Loaded 7 recipes [12:22:30 INFO]: Starting minecraft server version 1.20.1 [12:22:30 INFO]: Loading properties [12:22:30 INFO]: This server is running Paper version git-Paper-98 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: a40e48f) ``` The paper version I am using is old, that might be an issue.
Norbiros commented 2023-08-11 12:36:02 +00:00 (Migrated from github.com)

Can you reproduce this problem while using 1.19.4 version od mc-bots?

Can you reproduce this problem while using 1.19.4 version od mc-bots?
bananasmoothii commented 2023-08-12 14:38:37 +00:00 (Migrated from github.com)

I will do this in about 10 days, feel free to ping me if I forget

I will do this in about 10 days, feel free to ping me if I forget
Sign in to join this conversation.