Lncvrt/mc-bots
1
0 Fork 0
Code Issues 15 Pull Requests 1 Actions Packages Projects Releases 20 Wiki Activity

Requesting PR for 1.19.1 (and 1.19.2) #44

Merged
isu-kim merged 8 commits from main into main 2022-08-16 12:03:14 +00:00
Conversation 1 Commits 8 Files Changed 5
+127 -22
isu-kim commented 2022-08-16 09:25:53 +00:00 (Migrated from github.com)
Copy link
Copy source

Feature

1.19.1 and 1.19.2 support since MCProtocollib supports 1.19.1 finally!

Changes

  • Update package version to 1.2.5
  • Change build.gradle settings for 1.19.1-SNAPSHOT (since MCProtocollib uses 1.19.1-SNAPSHOT currently)
  • Update ServerboundChatCommandPacket for newer version of API.
  • Update bot receiving chats due to getSignedContent method getting deleted.
  • Update on bot receiving chat format to Username : Chat Message since the old method will not work anymore.
  • Update getFullText methods for implementing newer version of API.
  • Refactor code a bit for receiving ClientboundSystemChatPacket and ClientboundPlayerChatPacket since it got updated.

ETC

  • Checked this code working with paper 1.19.1 and 1.19.2 on test server of mine
  • Thanks for reviewing!
## Feature 1.19.1 and 1.19.2 support since MCProtocollib supports 1.19.1 finally! ## Changes - Update package version to 1.2.5 - Change build.gradle settings for 1.19.1-SNAPSHOT (since MCProtocollib uses 1.19.1-SNAPSHOT currently) - Update `ServerboundChatCommandPacket` for newer version of API. - Update bot receiving chats due to `getSignedContent` method getting deleted. - Update on bot receiving chat format to `Username : Chat Message` since the old method will not work anymore. - Update `getFullText` methods for implementing newer version of API. - Refactor code a bit for receiving `ClientboundSystemChatPacket` and `ClientboundPlayerChatPacket` since it got updated. ## ETC - Checked this code working with paper 1.19.1 and 1.19.2 on test server of mine - Thanks for reviewing!
crpmax (Migrated from github.com) reviewed 2022-08-16 12:02:30 +00:00
crpmax (Migrated from github.com) left a comment
Copy link
Copy source

Looks great, thanks.

Looks great, thanks.
Sign in to join this conversation.
Reviewers
No Reviewers
crpmax
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Lncvrt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Lncvrt/mc-bots#44