gnulib: Drop no-abort.patch

Originally added in commit db7337a3d (grub-core/lib/posix_wrap/stdlib.h
(abort): Removed), this patched out all relevant invocations of abort()
in gnulib. While it was not documented why at the time, testing suggests
that there's no abort() implementation available for gnulib to use.

gnulib's position is that the use of abort() is correct here, since it
happens when input violates a "shall" from POSIX. Additionally, the
code in question is probably not reachable. Since abort() is more
friendly to user-space, they prefer to make no change, so we can just
carry a define instead (suggested by Paul Eggert).

Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Robbie Harwood authored and Daniel Kiper committed 2022-03-21 18:58:44 +01:00
1 parent ea780522e1
commit cd37d3d391
4 files changed
+11 -28

No files matched your search

+10
View File
@@ -70,6 +70,16 @@
# ifndef _GL_INLINE_HEADER_BEGIN
# define _GL_ATTRIBUTE_CONST __attribute__ ((const))
/*
* We don't have an abort() for gnulib to call in regexp. Because gnulib is
* built as a separate object that is then linked with, it doesn't have any
* of our headers or functions around to use - so we unfortunately can't
* print anything. Builds of emu include the system's stdlib, which includes
* a prototype for abort(), so leave this as a macro that doesn't take
* arguments.
*/
# define abort __builtin_trap
# endif /* !_GL_INLINE_HEADER_BEGIN */
#endif