Lncvrt/grub
1
0 Fork 0
mirror of https://git.savannah.gnu.org/git/grub.git synced 2026-10-21 14:59:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

term/serial: Use grub_strncpy() instead of grub_snprintf() when only copying string

Browse Source 
Using grub_strncpy() instead of grub_snprintf() is less overhead and
indicates clearly that the dest should be the same string as the source.

Also fix indentation.

Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Glenn Washburn authored and Daniel Kiper committed 2023-07-03 14:07:49 +02:00
1 parent 7c1a022d78
commit 712309eaae
1 file changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files
grub-core/term/serial.c
+3 -3
View File
@@ -257,10 +257,10 @@ grub_cmd_serial (grub_extcmd_context_t ctxt, int argc, char **args)
{ {
if (grub_strncmp (state[OPTION_PORT].arg, "mmio,", sizeof ("mmio,") - 1) == 0 || if (grub_strncmp (state[OPTION_PORT].arg, "mmio,", sizeof ("mmio,") - 1) == 0 ||
grub_strncmp (state[OPTION_PORT].arg, "pci,", sizeof ("pci,") - 1) == 0) grub_strncmp (state[OPTION_PORT].arg, "pci,", sizeof ("pci,") - 1) == 0)
grub_snprintf (pname, sizeof (pname), "%s", state[1].arg); grub_strncpy (pname, state[1].arg, sizeof (pname));
else else
grub_snprintf (pname, sizeof (pname), "port%lx", grub_snprintf (pname, sizeof (pname), "port%lx",
grub_strtoul (state[1].arg, 0, 0)); grub_strtoul (state[1].arg, 0, 0));
name = pname; name = pname;
} }