Lncvrt/grub
1
0 Fork 0
mirror of https://git.savannah.gnu.org/git/grub.git synced 2026-10-23 07:39:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

gfxmenu: Fix double free in load_image()

Browse Source 
self->bitmap should be zeroed after free. Otherwise, there is a chance
to double free (USE_AFTER_FREE) it later in rescale_image().

Fixes: CID 292472

Signed-off-by: Alexey Makhalov <amakhalov@vmware.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Alexey Makhalov authored and Daniel Kiper committed 2020-07-29 16:55:48 +02:00
1 parent 89f3da1a3d
commit 26a8c19307
1 file changed
+4 -1
Download Patch File Download Diff File Expand all files Collapse all files
grub-core/gfxmenu/gui_image.c
+4 -1
View File
@@ -195,7 +195,10 @@ load_image (grub_gui_image_t self, const char *path)
return grub_errno; return grub_errno;
if (self->bitmap && (self->bitmap != self->raw_bitmap)) if (self->bitmap && (self->bitmap != self->raw_bitmap))
grub_video_bitmap_destroy (self->bitmap); {
grub_video_bitmap_destroy (self->bitmap);
self->bitmap = 0;
}
if (self->raw_bitmap) if (self->raw_bitmap)
grub_video_bitmap_destroy (self->raw_bitmap); grub_video_bitmap_destroy (self->raw_bitmap);