Lncvrt/grub
1
0 Fork 0
mirror of https://git.savannah.gnu.org/git/grub.git synced 2026-10-21 14:59:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

commands/efi/efifwsetup: Add missing grub_free()s

Browse Source 
Each call of grub_efi_get_variable() needs a grub_free().

Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Robbie Harwood authored and Daniel Kiper committed 2022-08-20 00:19:00 +02:00
1 parent a032782c86
commit 01d1953fc5
1 file changed
+8 -3
Download Patch File Download Diff File Expand all files Collapse all files
grub-core/commands/efi/efifwsetup.c
+8 -3
View File
@@ -44,6 +44,8 @@ grub_cmd_fwsetup (grub_command_t cmd __attribute__ ((unused)),
if (old_os_indications != NULL && oi_size == sizeof (os_indications)) if (old_os_indications != NULL && oi_size == sizeof (os_indications))
os_indications |= *old_os_indications; os_indications |= *old_os_indications;
grub_free (old_os_indications);
status = grub_efi_set_variable ("OsIndications", &global, &os_indications, status = grub_efi_set_variable ("OsIndications", &global, &os_indications,
sizeof (os_indications)); sizeof (os_indications));
if (status != GRUB_ERR_NONE) if (status != GRUB_ERR_NONE)
@@ -62,17 +64,20 @@ efifwsetup_is_supported (void)
grub_efi_uint64_t *os_indications_supported = NULL; grub_efi_uint64_t *os_indications_supported = NULL;
grub_size_t oi_size = 0; grub_size_t oi_size = 0;
grub_efi_guid_t global = GRUB_EFI_GLOBAL_VARIABLE_GUID; grub_efi_guid_t global = GRUB_EFI_GLOBAL_VARIABLE_GUID;
grub_efi_boolean_t ret = 0;
grub_efi_get_variable ("OsIndicationsSupported", &global, &oi_size, grub_efi_get_variable ("OsIndicationsSupported", &global, &oi_size,
(void **) &os_indications_supported); (void **) &os_indications_supported);
if (!os_indications_supported) if (!os_indications_supported)
return 0; goto done;
if (*os_indications_supported & GRUB_EFI_OS_INDICATIONS_BOOT_TO_FW_UI) if (*os_indications_supported & GRUB_EFI_OS_INDICATIONS_BOOT_TO_FW_UI)
return 1; ret = 1;
return 0; done:
grub_free (os_indications_supported);
return ret;
} }
GRUB_MOD_INIT (efifwsetup) GRUB_MOD_INIT (efifwsetup)